Enable llpm sample for nrf7120 #23179

rob-robinson-14 · 2025-07-07T16:46:52Z

Changes required to run llpm sample on nrf7120.

NordicBuilder · 2025-07-07T16:50:28Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 9204e64bc33918b0524eb99a1c5b32787eb33deb

more details

sdk-nrf:

PR head: 9204e64bc33918b0524eb99a1c5b32787eb33deb
merge base: d2d7781facdbeeec8506337e9964b7fd8ff12ee9
target head (main): 1f2eb23e4faf59848f6d963d95f893a86fc3d0b3
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (7)

boards
│  ├── nordic
│  │  ├── nrf7120pdk
│  │  │  ├── nrf7120pdk_nrf7120_cpuapp.dts
│  │  │  │ nrf7120pdk_nrf7120_cpuapp_emu.dts
drivers
│  ├── entropy
│  │  ├── Kconfig
│  │  │ Kconfig.nrf_prng
samples
│  ├── bluetooth
│  │  ├── llpm
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  ├── src
│  │  │  │  │ main.c
subsys
│  ├── bluetooth
│  │  ├── controller
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: 684b32e022
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:684b32e022_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 30
✅ Integration tests
- ✅ desktop52_verification
- ✅ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nrf_crypto
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-thread-main
- ✅ test-sdk-find-my

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_mosh
- test-fw-nrfconnect-nrf_lrcs_positioning
- doc-internal
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-low-level
- test-sdk-audio
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-07-07T17:12:14Z

You can find the documentation preview for this PR here.

Enable BT_CTLR_SDC_LLPM for nRF7120 Signed-off-by: Robert Robinson <[email protected]>

Add nRF7120 to FAKE_ENTROPY_NRF_PRNG config Enabled prng for zephyr,entropy on nRF7120 Signed-off-by: Robert Robinson <[email protected]>

NordicBuilder · 2025-07-10T15:39:22Z

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: ROM size increased by 4712[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_keyboard[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1196[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 4624[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 564[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54lm20a/cpuapp]: ROM size increased by 1952[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 4672[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.matter.template.debug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 8424[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf52840dk/nrf52840]: ROM size increased by 8256[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54lm20a/cpuapp]: ROM size increased by 1952[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: ROM size increased by 1204[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.matter.template.debug[nrf52840dk/nrf52840]: ROM size increased by 8424[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug_keyboard.uart.kmu_provision[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 6368[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.matter.template.release[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 8088[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: ROM size increased by 1196[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: ROM size increased by 8264[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 520[B] in comparison to the main[d2d7781] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: ROM size increased by 8324[B] in comparison to the main[d2d7781] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23179/9)

On devices where security manager has not yet been implemented, it is useful to still be able to test bluetooth functionality through llpm sample. Signed-off-by: Robert Robinson <[email protected]>

nordicjm · 2025-07-14T11:52:59Z

drivers/entropy/Kconfig.nrf_prng

+if ENTROPY_GENERATOR
+
+config FAKE_ENTROPY_NRF_PRNG
+	bool "A fake nRF entropy driver"
+	default y
+	depends on DT_HAS_NORDIC_ENTROPY_PRNG_ENABLED
+	depends on (SOC_SERIES_NRF54HX || SOC_SERIES_NRF92X || SOC_SERIES_NRF54LX || SOC_SERIES_NRF71X)
+	select ENTROPY_HAS_DRIVER
+	help
+	  This is a super simple PRNG driver that can be used on nRF platforms that
+	  do not have an entropy source.
+	  This is NOT SAFE to use for cryptographic operations!


No, this already exists in zephyr and properly emits a warning with:

CONFIG_TEST_RANDOM_GENERATOR=y CONFIG_TIMER_RANDOM_GENERATOR=y CONFIG_TEST_CSPRNG_GENERATOR=y

nordicjm · 2025-07-14T11:53:32Z

samples/bluetooth/llpm/src/main.c

 			printk("Failed to set security: %d\n", err);
 		}
+#else
+		/*Start service discovery*/


/* Comments start after a space */

rob-robinson-14 requested review from a team and Hi-Im-David as code owners July 7, 2025 16:46

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 7, 2025

rob-robinson-14 force-pushed the enable-llpm-sample-nrf7120 branch 6 times, most recently from 45c5d1e to 44559a4 Compare July 10, 2025 14:53

rob-robinson-14 added 2 commits July 10, 2025 15:53

nrf: subsys: bluetooth: controller: Enable BT_CTLR_SDC_LLPM for nRF7120

fe3b5ad

Enable BT_CTLR_SDC_LLPM for nRF7120 Signed-off-by: Robert Robinson <[email protected]>

nrf: boards: nordic: nrf7120pdk: Enable prng for zephyr,entropy

b987a8b

Add nRF7120 to FAKE_ENTROPY_NRF_PRNG config Enabled prng for zephyr,entropy on nRF7120 Signed-off-by: Robert Robinson <[email protected]>

rob-robinson-14 force-pushed the enable-llpm-sample-nrf7120 branch from 44559a4 to 01040ee Compare July 10, 2025 14:54

samples: bluetooth: llpm: Enable sample to run without security protocol

9204e64

On devices where security manager has not yet been implemented, it is useful to still be able to test bluetooth functionality through llpm sample. Signed-off-by: Robert Robinson <[email protected]>

rob-robinson-14 force-pushed the enable-llpm-sample-nrf7120 branch from 01040ee to 9204e64 Compare July 11, 2025 07:51

nordicjm requested changes Jul 14, 2025

View reviewed changes

nordicjm reviewed Jul 14, 2025

View reviewed changes

rob-robinson-14 closed this Jul 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable llpm sample for nrf7120 #23179

Enable llpm sample for nrf7120 #23179

Uh oh!

rob-robinson-14 commented Jul 7, 2025 •

edited

Loading

Uh oh!

NordicBuilder commented Jul 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 7, 2025

Uh oh!

NordicBuilder commented Jul 10, 2025 •

edited

Loading

Uh oh!

nordicjm Jul 14, 2025

Uh oh!

nordicjm Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Enable llpm sample for nrf7120 #23179

Enable llpm sample for nrf7120 #23179

Uh oh!

Conversation

rob-robinson-14 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions bot commented Jul 7, 2025

Uh oh!

NordicBuilder commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory footprint analysis revealed the following potential issues

Uh oh!

nordicjm Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rob-robinson-14 commented Jul 7, 2025 •

edited

Loading

NordicBuilder commented Jul 7, 2025 •

edited

Loading

NordicBuilder commented Jul 10, 2025 •

edited

Loading